Skip to content

Stop using deprecated urllib3 API #2170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

arcivanov
Copy link
Contributor

fixes #2169

What type of PR is this?

/kind cleanup
/kind deprecation

What this PR does / why we need it:

Stop using deprecated urllib3 API.

Which issue(s) this PR fixes:

Fixes #2169

Special notes for your reviewer:

Does this PR introduce a user-facing change?

No.


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

  • 5b9afe2 Stop using deprecated urllib3 API

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 26, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @arcivanov!

It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: arcivanov
Once this PR has been reviewed and has the lgtm label, please assign yliaog for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 26, 2023
@yliaog
Copy link
Contributor

yliaog commented Dec 28, 2023

as the start of the file shows:

Generated by: https://openapi-generator.tech

the file is generated, fix needs to go to the generator.

@arcivanov
Copy link
Contributor Author

@yliaog will do, thanks!

@arcivanov arcivanov closed this Dec 28, 2023
@arcivanov
Copy link
Contributor Author

@yliaog well, this is curious. Openapi-generator for python switched to httpx from requests in the year 2020: https://github.com/openapi-generators/openapi-python-client/blob/fe76d59a2bae07b884cca75304734762547557e1/CHANGELOG.md#020---2020-03-22

What version of the generator are we even using?

@yliaog
Copy link
Contributor

yliaog commented Dec 28, 2023

export OPENAPI_GENERATOR_COMMIT="v4.3.0"

export OPENAPI_GENERATOR_COMMIT="v4.3.0"

@arcivanov
Copy link
Contributor Author

arcivanov commented Dec 29, 2023

@yliaog the version v4.3.0 is prehistoric as well (current is 7.2.0) and I feel there is a zero chance that the upstream will entertain a patch at this point in time.

Would you be amenable to a post-generation patch file similar to this?

git apply "${SCRIPT_ROOT}/rest_client_patch.diff"

@arcivanov
Copy link
Contributor Author

@yliaog
Copy link
Contributor

yliaog commented Jan 2, 2024

a patch is fine, provide comment on why is the patch, and when it can be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop using deprecated urllib3 API
3 participants